Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔑 Add client cert auth #616

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

🔑 Add client cert auth #616

wants to merge 3 commits into from

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Dec 19, 2023

This adds 8080 to be used with client cert auth.
selfsigned-cli.p12 needs to be imported in browser's chain.

Password is empty.

Signed-off-by: tobiasKaminsky <[email protected]>
@AndyScherzinger AndyScherzinger changed the title Add client cert auth 🔑 Add client cert auth Jan 18, 2024
@nickvergessen
Copy link
Member

Can we name the files in a way that it's clear they are "localhost development" only, otherwise we will get useless h1 reports again

@tobiasKaminsky
Copy link
Member Author

Sure.
For my understanding the entire shallow-server/CI is for localhost dev or dev only.

What about something like"dev test key"?

@nickvergessen
Copy link
Member

For my understanding the entire shallow-server/CI is for localhost dev or dev only.

Yes, we all know. But script kiddies searching repos for BEGIN PRIVATE KEY do not know what shallow server means. it could be a production thing.

What about something like"dev test key"?

👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants